fix X-axis face occlusion#489
Merged
Merged
Conversation
Owner
|
<3 there are so many missing occlusion checks in the factory |
Contributor
Author
|
I can slowly chip away at some the easier ones if you want! I'm also noticing a few inconsistencies between inner and outer occlusion since I'm placing some builds aligned with the 32x32x32 grid. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a very small issue affecting more detailed builds but the occlusion check is flipped. Other functions use (1 - side) which is correct but not
generateXOuterOpaqueGeometry.Before:
After:
